[
https://issues.apache.org/jira/browse/HBASE-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146191#comment-14146191
]
Hudson commented on HBASE-12068:
--------------------------------
FAILURE: Integrated in HBase-1.0 #224 (See
[https://builds.apache.org/job/HBase-1.0/224/])
HBASE-12068 [Branch-1] Avoid need to always do KeyValueUtil#ensureKeyValue for
Filter transformCell. (anoopsamjohn: rev
af35daac777c06639d3eb1985def4846fda84cbb)
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RandomRowFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterAllFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterWrapper.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java
> [Branch-1] Avoid need to always do KeyValueUtil#ensureKeyValue for Filter
> transformCell
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-12068
> URL: https://issues.apache.org/jira/browse/HBASE-12068
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Affects Versions: 0.99.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.99.1
>
> Attachments: HBASE-12068.patch
>
>
> During read with Filters added to Scan/Get, the core code calls
> transformCell(Cell) on the Filter. Most of the filters do not implement
> transform API so the method from FilterBase will get executed
> {code}
> @Override
> public Cell transformCell(Cell v) throws IOException {
> // Old filters based off of this class will override KeyValue
> transform(KeyValue).
> // Thus to maintain compatibility we need to call the old version.
> return transform(KeyValueUtil.ensureKeyValue(v));
> }
> {code}
> Here always it do KeyValueUtil.ensureKeyValue. When a non KV cell comes in,
> we need recreate KV and do deep copy of key and value!
> We have to stick with this model in branch-1 for BC.
> So as a workaround to avoid possible KV convert, we can implement
> transformCell(Cell) method in all of our individual Filter classes which just
> return the incoming cell (So that method from FilterBase wont get executed)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
