[ 
https://issues.apache.org/jira/browse/HBASE-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147657#comment-14147657
 ] 

Anoop Sam John commented on HBASE-11920:
----------------------------------------

patch V6 LGTM
nit :
+ * @return the endpoint to use during replication. {@code null} if the default 
implementation is to
+ * be used.
Pls avoid saying "return null". Return the incoming instance itself is the best 
way. Just avoid that sentence.



> Add CP hooks for ReplicationEndPoint
> ------------------------------------
>
>                 Key: HBASE-11920
>                 URL: https://issues.apache.org/jira/browse/HBASE-11920
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, Replication
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: HBASE-11920.patch, HBASE-11920_1.patch, 
> HBASE-11920_2.patch, HBASE-11920_3.patch, HBASE-11920_4.patch, 
> HBASE-11920_6.patch
>
>
> If we want to create internal replication endpoints other than the one 
> created thro configuration we may need new hooks. This is something like an 
> internal scanner that we create during compaction so that the actual 
> compaction scanner can be used as a delegator.
> [~enis]
> If I can give a patch by tomorrow will it be possible to include in the RC?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to