[ 
https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096330#comment-13096330
 ] 

stack commented on HBASE-4206:
------------------------------

@Ron Can you attach your data generator code in case someone later has a 
similar issue and want to check their work or if an issue w/ this patch and 
they need to see how it was that the data generator found no issue w/ your 
patch above?  If you can't the above testimony works for me and I'll apply your 
patch...

> jenkins hash implementation uses longs unnecessarily
> ----------------------------------------------------
>
>                 Key: HBASE-4206
>                 URL: https://issues.apache.org/jira/browse/HBASE-4206
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.90.4
>            Reporter: Ron Yang
>            Priority: Minor
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: ryang.patch
>
>
> I don't believe you need to use long for a,b,c and as a result no longer need 
> to & against INT_MASK.
> At a minimum the private static longs should be made final, and the "main" 
> method should not print the absolute value of the hash but instead use 
> something like Integer.toHexString

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to