[jira] [Commented] (HBASE-12156) TableName cache isn't used for one of valueOf methods.

[Andrew Purtell (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158716#comment-14158716
 ] 

Andrew Purtell commented on HBASE-12156:
----------------------------------------

TestTableName is failing on 0.98. I can only get this test to pass reliably 
after the change on this issue if I run TestTableName in its own JVM. 

Definitely this change in TableName is good:
{code}
@@ -446,7 +446,7 @@ public final class TableName implements 
Comparable<TableName> {
     }
 
     for (TableName tn : tableCache) {
-      if (Arrays.equals(tn.getQualifier(), namespace) &&
+      if (Arrays.equals(tn.getQualifier(), qualifier) &&
           Arrays.equals(tn.getNamespace(), namespace)) {
         return tn;
       }
{code}
I am considering keeping this but reverting the test change. Should we do this 
in all branches? [~stack]


> TableName cache isn't used for one of valueOf methods.
> ------------------------------------------------------
>
>                 Key: HBASE-12156
>                 URL: https://issues.apache.org/jira/browse/HBASE-12156
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>             Fix For: 2.0.0, 0.98.7, 0.99.1
>
>         Attachments: HBASE-12156-addendum-0.98.patch, HBASE-12156.patch
>
>
> there is wrong comparison, copy&paste code compares namespace with qualifier 
> and namespace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)