[ 
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162269#comment-14162269
 ] 

Hadoop QA commented on HBASE-11542:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12673345/HBASE-11542-5.patch
  against trunk revision .
  ATTACHMENT ID: 12673345

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +       Constructor<?> certValidityConstr = 
certValidityClass.getConstructor(new Class[] {Date.class, Date.class});
+       Class<?> certificateSerialNumberClass = 
Class.forName(getCertificateSerialNumberModuleName());
+       Constructor<?> certificateSerialNumberConstr = 
certificateSerialNumberClass.getConstructor(new Class[] {BigInteger.class});
+       methodSET.invoke(certInfoObject, 
getSetField(certInfoObject,"SERIAL_NUMBER"), certificateSerialNumberObject);
+       Constructor<?> certificateSubjectNameConstr = 
certificateSubjectNameClass.getConstructor(new Class[] {x500NameClass});
+       Object certificateSubjectNameObject = 
certificateSubjectNameConstr.newInstance(x500NameObject);
+       methodSET.invoke(certInfoObject, getSetField(certInfoObject,"SUBJECT"), 
certificateSubjectNameObject);
+       Constructor<?> certificateIssuerNameConstr = 
certificateIssuerNameClass.getConstructor(new Class[] {x500NameClass});
+       methodSET.invoke(certInfoObject, getSetField(certInfoObject,"ISSUER"), 
certificateIssuerNameObject);
+       //info.set(X509CertInfo.KEY, new CertificateX509Key(pair.getPublic())); 
getCertificateX509KeyModuleName

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//console

This message is automatically generated.

> Unit Test  KeyStoreTestUtil.java compilation failure in IBM JDK 
> ----------------------------------------------------------------
>
>                 Key: HBASE-11542
>                 URL: https://issues.apache.org/jira/browse/HBASE-11542
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, test
>    Affects Versions: 0.99.0
>         Environment: RHEL 6.3 ,IBM JDK 6
>            Reporter: LinseyPang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, 
> HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, 
> hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch
>
>
> In trunk,  jira HBase-10336 added a utility test KeyStoreTestUtil.java, which 
> leverages the following sun classes:
>    import sun.security.x509.AlgorithmId;
>    import sun.security.x509.CertificateAlgorithmId;
>   ....
> this cause hbase compiler failure if using IBM JDK,  
> There are similar classes like below in IBM jdk: 
> import com.ibm.security.x509.AlgorithmId;
> import com.ibm.security.x509.CertificateAlgorithmId; 
> This jira is to add handling of the x509 references. 
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to