[
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163015#comment-14163015
]
Anoop Sam John commented on HBASE-10536:
----------------------------------------
bq.a "--no-strict" flag instead
Can the -D option also named this way? Now it is strict. Go with --no-strict
and if passed as true avoid the early out. This will default to false.
if(strict == null || !strict.equals("false")) {
Can make use of Boolean.valueOf?
{code}
+ for (HColumnDescriptor family : families) {
+ familyNames.add(family.getNameAsString());
+ }
+ ArrayList<String> unmatchedFamilies = new ArrayList<String>();
+ Set<String> cfSet = getColumnFamilies(columns);
+ for (String cf : cfSet) {
+ if (!familyNames.contains(cf)) {
{code}
Just use HTD#getFamily(final byte [] column) to check whether the family name
is available? Code will look simpler.
Pls avoid white spaces from patch.
> ImportTsv should fail fast if any of the column family passed to the job is
> not present in the table
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-10536
> URL: https://issues.apache.org/jira/browse/HBASE-10536
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
> Affects Versions: 0.98.0
> Reporter: rajeshbabu
> Assignee: denny joseph
> Fix For: 2.0.0
>
> Attachments: HBASE-10536.patch, HBASE-10536.patch
>
>
> While checking 0.98 rc, running bulkload tools. By mistake passed wrong
> column family to importtsv. LoadIncrementalHfiles failed with following
> exception
> {code}
> Exception in thread "main" java.io.IOException: Unmatched family names found:
> unmatched family names in HFiles to be bulkloaded: [f1]; valid family names
> of table test are: [f]
> at
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
> at
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> at
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
> {code}
>
> Its better to fail fast if any of the passed column family is not present in
> table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
