[ 
https://issues.apache.org/jira/browse/HBASE-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168979#comment-14168979
 ] 

Ashish Singhi commented on HBASE-5742:
--------------------------------------

I checked this in the master branch. ZooKeeperConnectionException and 
MasterNotRunningException will actually be never thrown. They exist just to 
avoid backward incompatibility as the java doc also says
{code}
@throws MasterNotRunningException, ZooKeeperConnectionException are not
   *  thrown anymore but kept into the interface for backward api 
compatibility{code}

Should we resolve this as Won't fix ?

> LoadIncrementalHFiles throws too generic of an exception
> --------------------------------------------------------
>
>                 Key: HBASE-5742
>                 URL: https://issues.apache.org/jira/browse/HBASE-5742
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: David Capwell
>            Assignee: Ashish Singhi
>
> In 0.90 the LoadIncrementalHFiles constructor did not throw an exception, now 
> it throws Exception.  The constructor should ether not throw an exception or 
> throw ZooKeeperConnectionException, and MasterNotRunningException since those 
> come from the HBaseAdmin call.
> https://github.com/apache/hbase/blob/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java#L105



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to