Sean Busbey created HBASE-12256:
-----------------------------------
Summary: Update patch submission guidelines to call out binary
file support
Key: HBASE-12256
URL: https://issues.apache.org/jira/browse/HBASE-12256
Project: HBase
Issue Type: Improvement
Components: documentation
Reporter: Sean Busbey
Priority: Minor
Our guidelines should call out where users need to take special care if they
have binary files in their diff. (binary files here means anything {{file}}
detects as "data")
By default {{git diff}} won't include binary files, instead it'll just say
something like "binary files differ". That'll render the patch useless.
* Update reasons to favor format-patch to include "can handle binary files
changing by default".
* Add a note on {{git diff}} (or change the default args) to use {{--binary}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
