[ 
https://issues.apache.org/jira/browse/HBASE-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171270#comment-14171270
 ] 

Ted Yu commented on HBASE-12250:
--------------------------------

{code}
+    admin.updateConfiguration(server);
{code}
Should there be some assertion around the above invocation ?
{code}
+  public UpdateConfigurationResponse updateConfiguration(
+      RpcController controller, UpdateConfigurationRequest request)
+      throws ServiceException {
+    // TODO Auto-generated method stub
{code}
Remove TODO above.
{code}
+    conf.reloadConfiguration();
+    // TODO Notify all the observers that the configuration has changed.
{code}
Would the TODO be done in the next patch ?

> Adding an endpoint for updating the regionserver config
> -------------------------------------------------------
>
>                 Key: HBASE-12250
>                 URL: https://issues.apache.org/jira/browse/HBASE-12250
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Manukranth Kolloju
>            Assignee: Manukranth Kolloju
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: 
> 0001-Add-admin-endpoint-for-updating-the-configuration-on.patch, 
> 0001-Add-admin-endpoint-for-updating-the-configuration-on.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> This is a follow up Jira that adds the end point for updating the 
> configuration on the regionserver. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to