[ 
https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171388#comment-14171388
 ] 

stack commented on HBASE-12247:
-------------------------------

This one is a bit odd:

  * @returns A reference to this instance.

If I read it right, this method is a void retrun so this javadoc is not right

Otherwise patch is good.  Waiting on hadoopqa. If you agree on above, I can fix 
on commit.

> Replace setHTable() with initializeTable() in TableInputFormat.
> ---------------------------------------------------------------
>
>                 Key: HBASE-12247
>                 URL: https://issues.apache.org/jira/browse/HBASE-12247
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.99.2
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>         Attachments: HBASE-12247.patch
>
>
> TableInputFormat uses a new HTable().  Switch that use to a manually created 
> ConnectionFactory.createConnection() and call initializeTable().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to