[
https://issues.apache.org/jira/browse/HBASE-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172603#comment-14172603
]
Sean Busbey commented on HBASE-12269:
-------------------------------------
{quote}
1) In the thrift interface the elements are numbered.
- Is it better to put "the new thing I'm building" in a logical place
(i.e. somewhere in the middle causing all later fields to get a different
number)
- or to put it at the end?
{quote}
Please put it at the end. Changing field numbers will break compatibility.
{quote}
2) Apparently the generated thrift code has been committed to version
control.
- Should the changes in these classes be part of my patch?
{quote}
Yes.
{quote}
- If so, which version of thrift should be used (0.9.0/0.9.1/... ?) and
what is the 100% accurate correct command to generate them?
{quote}
You should use the {{thrift.version}} in master's pom.xml. At the moment that
is 0.9.0.
[Instructions on generating the classes can be found in the thrift2 package
docs|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html]
(and similarly for [the original thrift interface in the thrift
package|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html])
{quote}
- For my own purpose I created a small shell script so I can repeat the
command I have now (see below). Shall I include this as a separate script
in my patch?
The script I created here is hbase-thrift/generate-thrift-classes.sh
#!/bin/bash
thrift -v --gen java -out src/main/java/
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
thrift -v --gen java -out src/main/java/
src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
{quote}
I would leave this out, since it is not part of the current issue. I'd love to
improve our thrift handling, so if you want to make a follow on issue that'd be
great. At a minimum the script would have to be expanded to verify that the
correct version of thrift is being used. It should also be tied to maven.
> Add support for Scan.setRowPrefixFilter to thrift
> -------------------------------------------------
>
> Key: HBASE-12269
> URL: https://issues.apache.org/jira/browse/HBASE-12269
> Project: HBase
> Issue Type: New Feature
> Components: Thrift
> Reporter: Niels Basjes
>
> I think having the feature introduced in HBASE-11990 in the hbase thrift
> interface would be very useful.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
