[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172699#comment-14172699
]
Hadoop QA commented on HBASE-12261:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675057/0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
against trunk revision .
ATTACHMENT ID: 12675057
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 55 javac compiler
warnings (more than the trunk's current 53 warnings).
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ echo "$MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
+ $MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
+ trunkCheckstyleErrors=`$GREP '<error' $PATCH_DIR/trunkCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+ patchCheckstyleErrors=`$GREP '<error' $PATCH_DIR/patchCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+ {color:red}-1 javac{color}. The applied patch generated
$patchCheckstyleErrors checkstyle errors (more than the trunk's current
$trunkCheckstyleErrors errors)."
+ echo "There were $patchCheckstyleErrors checkstyle errors in this patch
compared to $trunkCheckstyleErrors on master."
+ {color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//console
This message is automatically generated.
> Add checkstyle to HBase build process
> -------------------------------------
>
> Key: HBASE-12261
> URL: https://issues.apache.org/jira/browse/HBASE-12261
> Project: HBase
> Issue Type: Bug
> Components: build, site
> Affects Versions: 2.0.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 2.0.0, 0.98.8, 0.99.2
>
> Attachments: 0001-Add-checkstyle.patch,
> 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
>
>
> We should add checkstyle to hadoop qa for our builds. That would free
> committers up from checking patches for stylistic issues and leave them free
> to check the real meat of the patches.
> Additionally we should have the check for empty try catch blocks running so
> that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
