[ 
https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated HBASE-12272:
---------------------------------
    Attachment: HBASE-12272-2014-10-15-v1-PREVIEW.patch

This is a first rough patch to validate the implementation direction.

I chose not to use https://github.com/dtrott/maven-thrift-plugin because it 
doesn't allow doing all the settings that are needed.

This implementation simply runs directly from Maven
* bash to check the thrift version
* thrift to create the files for 'thrift' and 'thrift2'

I consider this a viable solution because there are only two thrift files to 
generate files for.
The complete patch (this is only the pom.xml) must include deleting all the 
generated files currently under source control.

Note that this does require developers and Jenkins to have thrift installed.
[~busbey] Could you provide some feedback about this first draft version?
Thanks.

> Generating Thrift code automatically
> ------------------------------------
>
>                 Key: HBASE-12272
>                 URL: https://issues.apache.org/jira/browse/HBASE-12272
>             Project: HBase
>          Issue Type: Improvement
>          Components: Thrift
>            Reporter: Niels Basjes
>         Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch
>
>
> The generated thrift code is currently under source control.
> This should be generated automatically during the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to