[
https://issues.apache.org/jira/browse/HBASE-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099311#comment-13099311
]
Ted Yu commented on HBASE-4344:
-------------------------------
In HFileReaderV2.java, the following code isn't used:
{code}
+ private int keyValueLenSizeWithoutMemstoreTS() {
+ //KEY_VALUE_LEN_SIZE
+ if (this.includeMemstoreTS)
+ return 2 * Bytes.SIZEOF_INT + Bytes.SIZEOF_LONG;
+ else
+ return 2 * Bytes.SIZEOF_INT;
+ }
{code}
> Persist memstoreTS to disk
> --------------------------
>
> Key: HBASE-4344
> URL: https://issues.apache.org/jira/browse/HBASE-4344
> Project: HBase
> Issue Type: Sub-task
> Reporter: Amitanand Aiyer
> Assignee: Amitanand Aiyer
> Fix For: 0.89.20100924
>
> Attachments: patch-2
>
>
> Atomicity can be achieved in two ways -- (i) by using a multiversion
> concurrency system (MVCC), or (ii) by ensuring that "new" writes do not
> complete, until the "old" reads complete.
> Currently, Memstore uses something along the lines of MVCC (called RWCC for
> read-write-consistency-control). But, this mechanism is not incorporated for
> the key-values written to the disk, as they do not include the memstore TS.
> Let us make the two approaches be similar, by persisting the memstoreTS along
> with the key-value when it is written to the disk.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
