[
https://issues.apache.org/jira/browse/HBASE-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179359#comment-14179359
]
Nick Dimiduk commented on HBASE-12288:
--------------------------------------
Do you not want to use BB in this API as well?
{noformat}
- protected void createKeyOnlyKeyValue(byte[] keyBuffer, long memTS) {
+ protected void setKey(byte[] keyBuffer, long memTS) {
{noformat}
Does this change not lose fidelity in this context? Is this okay?
{noformat}
- private TagCompressionContext tagCompressionContext;
+ private boolean tagsCompressed;
{noformat}
Where you have added this comment
{noformat}
+ // result is HBB. So no problem of calling array()/ arrayOffset()
{noformat}
instead consider adding an assertion {{assert !bb.isDirect()}}
nit, this comment is difficult to read
{noformat}
+ * Note : This will advance the position in <code>out</code> buffer but no
change in position for
+ * the position in <code>in</code> buffer.
{noformat}
I think you mean something like
{noformat}
This will advance the position marker of {@code out} but not change the
position maker for {@code in}.
{noformat}
> Support DirectByteBuffer usage in DataBlock Encoding area
> ---------------------------------------------------------
>
> Key: HBASE-12288
> URL: https://issues.apache.org/jira/browse/HBASE-12288
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-12288.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
