[ 
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184997#comment-14184997
 ] 

Anoop Sam John commented on HBASE-10201:
----------------------------------------

{code}
+      // ------------------------------------------------------------------
+      // STEP 6. Record oldest sequence id of memstore
+      // ------------------------------------------------------------------
+      long seqId = walKey.getSequenceId();
+      for (Store store: storesUpdated) {
+        store.setSeqIdOfOldestEdit(seqId);
+      }
+
       // -------------------------------
-      // STEP 6. Release row locks, etc.
+      // STEP 7. Release row locks, etc.
       // -------------------------------
       if (locked) {
         this.updatesLock.readLock().unlock();
{code}
Adding this step here under rowlocks will make us wait more and will affect 
write throughput. [~stack] done some test related to this in another Jira.

> Port 'Make flush decisions per column family' to trunk
> ------------------------------------------------------
>
>                 Key: HBASE-10201
>                 URL: https://issues.apache.org/jira/browse/HBASE-10201
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>         Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, 
> HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201.patch
>
>
> Currently the flush decision is made using the aggregate size of all column 
> families. When large and small column families co-exist, this causes many 
> small flushes of the smaller CF. We need to make per-CF flush decisions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to