[
https://issues.apache.org/jira/browse/HBASE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100493#comment-13100493
]
[email protected] commented on HBASE-4057:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1750/#review1817
-----------------------------------------------------------
Ship it!
Took a quick look at the patch -- looks good -- then I tried it. Its lovely.
+1 on commit.
- Michael
On 2011-09-08 15:35:10, Riley Patterson wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1750/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-08 15:35:10)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Includes extended TaskMonitor with consideration for high-frequency, short
duration changes, a new MonitoredRPCHandler class, integration with the RPC,
and filtered exposure both as and HTML table and as JSON via jamon.
bq.
bq.
bq. This addresses bug HBASE-4057.
bq. https://issues.apache.org/jira/browse/HBASE-4057
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandler.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java
1166510
bq. /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1166510
bq. /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
1166510
bq. /src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
1166510
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1166510
bq. /src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
1166510
bq. /src/main/jamon/org/apache/hbase/tmpl/common/TaskMonitorTmpl.jamon
1166510
bq.
/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTask.java
1166510
bq. /src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java
1166510
bq. /src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java
1166510
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
1166510
bq. /src/main/resources/hbase-webapps/static/hbase.css 1166510
bq. /src/test/java/org/apache/hadoop/hbase/monitoring/TestTaskMonitor.java
1166510
bq.
bq. Diff: https://reviews.apache.org/r/1750/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed. All exposure works as expected. Extensive load
testing has been done on FB's internal branch.
bq.
bq.
bq. Thanks,
bq.
bq. Riley
bq.
bq.
> Implement HBase version of "show processlist"
> ---------------------------------------------
>
> Key: HBASE-4057
> URL: https://issues.apache.org/jira/browse/HBASE-4057
> Project: HBase
> Issue Type: New Feature
> Components: client, regionserver
> Reporter: Nicolas Spiegelberg
> Assignee: Riley Patterson
> Attachments: HBASE-4057.patch
>
>
> One of the features that our DBAs use for MySQL analysis is "show
> processlist", which gives application-level stats about the RPC threads.
> Right now, we use jstack but that is very core-developer-centric. We need to
> create a similar tool that DBA/Ops/AppDevs can use.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
