[
https://issues.apache.org/jira/browse/HBASE-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186429#comment-14186429
]
Anoop Sam John commented on HBASE-12345:
----------------------------------------
bq.Should this API include the buf.arrayOffset() or should the caller pass the
offset that has considered buf.arrayOffset? Atleast in the HBASE read path code
the offset is including hte buf.arrayOffset.
I think internally the util should handle it as in the patch. Else the user of
the API need to know whether this is a direct buffer or not.
bq.There is a variation that takes a long getInt(long a), getLong(long a),
getShort(long a).
The above code is using this long taking method only. DirectBuffer#address()
returns a long.
bq.Also the DBB code does an << 0 operation.
You mean in this patch? Where?
> Unsafe based Comparator for BB
> -------------------------------
>
> Key: HBASE-12345
> URL: https://issues.apache.org/jira/browse/HBASE-12345
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-12345.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
