[ 
https://issues.apache.org/jira/browse/HBASE-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188051#comment-14188051
 ] 

stack commented on HBASE-12358:
-------------------------------

bq. So the doc in some time.

Suggest sooner rather than later.  Doesn't have to be fancy and can change as 
we learn stuff.  Its just handy to have a reference doc because its hard to 
track across JIRAs.  Thanks.

bq. Some of Andy's experiments shown that the position/limit checks in nio BB 
impls makes the perf bad and not getting inlining also. 

Yeah. Can look at what others have done too to get the speed up.  Netty good 
because has refcounting but downside is we are not going to get netty bufs from 
dfsclient; we can deal.

bq. I would feel before doing that we should have our subtasks helping us out 
to achieve this.

Any POC'ing to do in here first? Will help figure the tasks.

bq. Can we do this way?

Would be good to try it first and be prepared to throw it away if it is awkward 
(I know its a bunch of work).

bq. Compression case am checking some way we can avoid. 

Yeah, hopefully no or minimal copying compressing.

[~ram_krish]
bq. I would feel before doing that we should have our subtasks helping us out 
to achieve this.

Would be good to have general direction decided before the subtasks?  A bit of 
POC'ing and a bit of spec how we are to proceed?  Then easy making up the 
subtasks.

bq.  APIs are in the read and which one in write then may be it may make sense 
to extend Cell only for the new BB based cell.

Hopefully we can avoid one way to write and another to read.

Thanks lads.  Let me look at HBASE-12282


> Create ByteBuffer backed Cell
> -----------------------------
>
>                 Key: HBASE-12358
>                 URL: https://issues.apache.org/jira/browse/HBASE-12358
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12358.patch
>
>
> As part of HBASE-12224 and HBASE-12282 we wanted a Cell that is backed by BB. 
>  Changing the core Cell impl would not be needed as it is used in server 
> only.  So we will create a BB backed Cell and use it in the Server side read 
> path. This JIRA just creates an interface that extends Cell and adds the 
> needed API.
> The getTimeStamp and getTypebyte() can still refer to the original Cell API 
> only.  The getXXxOffset() and getXXXLength() can also refer to the original 
> Cell only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to