[
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188070#comment-14188070
]
stack commented on HBASE-10201:
-------------------------------
bq. I think it is better to open another issue to handle the duplication.
OK.
bq. getEarliestFlushTimeForAllStore should be public because TestIOFencing use
it(which in another package).
FYI, we mark these with @VisibleForTesting annotation.. I can do on commit.
bq. ....but I see lots of other similar methods declared as public...
Yeah, sorry about that; we ain't always consistent.... trying.
bq. Does this meet the requirement?
Yes. Out of interest, are you using the hbase formatter?
bq. I tried but failed to make dev-support/test-patch.sh work properly...
Yeah, this stuff is focused on the master. Unit tests passing on branch-1
would be great. Just note it here in the issue.
You going to try hbase-it?
Thanks.
> Port 'Make flush decisions per column family' to trunk
> ------------------------------------------------------
>
> Key: HBASE-10201
> URL: https://issues.apache.org/jira/browse/HBASE-10201
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Ted Yu
> Assignee: zhangduo
> Priority: Critical
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch,
> HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch,
> HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_2.patch,
> HBASE-10201_3.patch
>
>
> Currently the flush decision is made using the aggregate size of all column
> families. When large and small column families co-exist, this causes many
> small flushes of the smaller CF. We need to make per-CF flush decisions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
