[ 
https://issues.apache.org/jira/browse/HBASE-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188184#comment-14188184
 ] 

Anoop Sam John commented on HBASE-12282:
----------------------------------------

bq.So how should the cell be created?  So based on the buffer from the 
HFileBlock we wil decide if it is a direct BB or on heap BB and create KV based 
on that ? That KV is either a normal KV that we use now (create cell based on 
buffer.array) or it would be a new KV which will have buffer in it?
IMHO just not worry abt DBB/HBB here. Always create a new KV type which 
implements new BBBackedBuffer.  We have optimization in Comparators etc to 
check based on hasArry() and do.

> Ensure Cells and its implementations work with Buffers also
> -----------------------------------------------------------
>
>                 Key: HBASE-12282
>                 URL: https://issues.apache.org/jira/browse/HBASE-12282
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: 0.99.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12224_2.patch
>
>
> This issue can be used to brainstorm and then do the necessary changes for 
> the offheap work.  All impl of cells deal with byte[] but when we change the 
> Hfileblocks/Readers to work purely with Buffers then the byte[] usage would 
> mean that always the data is copied to the onheap.  Cell may need some 
> interface change to implement this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to