[ 
https://issues.apache.org/jira/browse/HBASE-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188401#comment-14188401
 ] 

Matteo Bertozzi commented on HBASE-12375:
-----------------------------------------

cool, thanks for verifying that. 
+1 on the patch

If you want to do that, you can also change the _tmp stuff and get rid of all 
the if _ stuff
otherwise the patch is already good enough for me.
{code}
protected List<LoadQueueItem> splitStoreFile(final LoadQueueItem item,
...
// We use a '_' prefix which is ignored when walking directory trees above.
final Path tmpDir = new Path(item.hfilePath.getParent(), "_tmp");
{code}

> LoadIncrementalHFiles fails to load data in table when CF name starts with '_'
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-12375
>                 URL: https://issues.apache.org/jira/browse/HBASE-12375
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.5
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>         Attachments: HBASE-12375.patch
>
>
> We do not restrict user from creating a table having column family starting 
> with '_'.
> So when user creates a table in such a way then LoadIncrementalHFiles will 
> skip those family data to load into the table.
> {code}
> // Skip _logs, etc
> if (familyDir.getName().startsWith("_")) continue;
> {code}
> I think we should remove that check as I do not see any _logs directory being 
> created by the bulkload tool in the output directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to