[
https://issues.apache.org/jira/browse/HBASE-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190305#comment-14190305
]
stack commented on HBASE-11819:
-------------------------------
See style that is in the rest of the code base [~talat] See where we put
spacings or, better, install the eclipse style plugin. See '18.3.1.1. Code
Formatting' in refguide. For example, see how we do the spacing around '
}finally{' elsewhere in code base... There is a space after and before
parens....
This is good:
+ try{
+ // Create a table with 3 region
+ admin.createTable(htd, new byte[][] { rowSeperator1, rowSeperator2 });
+ util.waitUntilAllRegionsAssigned(testTable);
+ }finally{
+ admin.close();
+ }
... except, look up in the method and you'll see that admin is used doing table
exists and disable, etc. What if admin throws exception in these methods?
Almost there.
> Unit test for CoprocessorHConnection
> -------------------------------------
>
> Key: HBASE-11819
> URL: https://issues.apache.org/jira/browse/HBASE-11819
> Project: HBase
> Issue Type: Test
> Reporter: Andrew Purtell
> Assignee: Talat UYARER
> Priority: Minor
> Labels: newbie++
> Fix For: 2.0.0, 0.98.8, 0.99.2
>
> Attachments: HBASE-11819.patch, HBASE-11819v2.patch
>
>
> Add a unit test to hbase-server that exercises CoprocessorHConnection .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)