[
https://issues.apache.org/jira/browse/HBASE-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191364#comment-14191364
]
Hadoop QA commented on HBASE-12390:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678393/hbase-12390_v1.patch
against trunk revision .
ATTACHMENT ID: 12678393
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3780 checkstyle errors (more than the trunk's current 3774 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ <td><%
org.apache.hadoop.hbase.util.VersionInfo.getVersion() %>, revision=<%
org.apache.hadoop.hbase.util.VersionInfo.getRevision() %></td><td>HBase version
and revision</td>
+ <td><% org.apache.hadoop.util.VersionInfo.getVersion() %>,
revision=<% org.apache.hadoop.util.VersionInfo.getRevision() %></td>
+ <td><% org.apache.hadoop.hbase.util.VersionInfo.getVersion() %>,
revision=<% org.apache.hadoop.hbase.util.VersionInfo.getRevision() %></td>
+ <td><% org.apache.hadoop.util.VersionInfo.getVersion() %>,
revision=<% org.apache.hadoop.util.VersionInfo.getRevision() %></td>
+ <td><% org.apache.hadoop.util.VersionInfo.getDate() %>, <%
org.apache.hadoop.util.VersionInfo.getUser() %></td>
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestAcidGuarantees
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11534//console
This message is automatically generated.
> Change revision style from svn to git
> -------------------------------------
>
> Key: HBASE-12390
> URL: https://issues.apache.org/jira/browse/HBASE-12390
> Project: HBase
> Issue Type: Improvement
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Fix For: 2.0.0, 0.99.2
>
> Attachments: hbase-12390_v1.patch
>
>
> This was bothering me. We should change the {{-r <revision_id>}} style that
> is an svn thing.
> We can do:
> {code}
> 2.0.0-SNAPSHOT, revision=64b6109ce917a47e4fa4b88cdb800bcc7a228484
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)