[
https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191533#comment-14191533
]
Hadoop QA commented on HBASE-12392:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678433/HBASE-12392.diff
against trunk revision .
ATTACHMENT ID: 12678433
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11538//console
This message is automatically generated.
> Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
> -------------------------------------------------------------------
>
> Key: HBASE-12392
> URL: https://issues.apache.org/jira/browse/HBASE-12392
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: hbase-11339
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-12392.diff
>
>
> Now in the implementation of the isRetainDeleteMarkers method, the code look
> like,
> {code}
> return (this.retainDeleteMarkers != null) ?
> this.retainDeleteMarkers.booleanValue()
> : isAllFiles();
> {code}
> It means for a major compaction in a normal store, this method returns true.
> Consequently the delete marks could not be deleted in the major compaction,
> which leads the unit test TestKeepDeletes fails.
> The correct implementation should be,
> {code}
> return (this.retainDeleteMarkers != null) ?
> this.retainDeleteMarkers.booleanValue()
> : !isAllFiles();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
