[
https://issues.apache.org/jira/browse/HBASE-12219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192404#comment-14192404
]
Andrew Purtell commented on HBASE-12219:
----------------------------------------
0.98 patch doesn't apply cleanly:
{noformat}
patching file
hbase-server/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
patching file
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Hunk #1 succeeded at 362 (offset 3 lines).
Hunk #2 succeeded at 489 (offset 3 lines).
Hunk #3 succeeded at 811 with fuzz 1 (offset 3 lines).
patching file
hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
patching file
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Hunk #4 FAILED at 1309.
1 out of 10 hunks FAILED -- saving rejects to file
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java.rej
patching file
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
Hunk #3 FAILED at 88.
Hunk #4 FAILED at 120.
Hunk #5 FAILED at 130.
Hunk #6 FAILED at 147.
Hunk #7 succeeded at 197 (offset 7 lines).
Hunk #8 succeeded at 270 (offset 7 lines).
Hunk #9 succeeded at 289 (offset 7 lines).
Hunk #10 succeeded at 307 (offset 7 lines).
Hunk #11 succeeded at 321 (offset 7 lines).
Hunk #12 succeeded at 337 (offset 7 lines).
Hunk #13 succeeded at 356 (offset 7 lines).
Hunk #14 succeeded at 396 (offset 7 lines).
Hunk #15 succeeded at 421 (offset 7 lines).
Hunk #16 succeeded at 465 (offset 7 lines).
Hunk #17 succeeded at 473 (offset 7 lines).
Hunk #18 FAILED at 481.
Hunk #19 succeeded at 541 (offset 7 lines).
Hunk #20 succeeded at 581 (offset 7 lines).
Hunk #21 succeeded at 596 (offset 7 lines).
Hunk #22 succeeded at 622 (offset 7 lines).
Hunk #23 succeeded at 648 (offset 7 lines).
Hunk #24 succeeded at 686 (offset 7 lines).
Hunk #25 succeeded at 712 (offset 7 lines).
Hunk #26 succeeded at 720 (offset 7 lines).
Hunk #27 succeeded at 752 (offset 7 lines).
5 out of 27 hunks FAILED -- saving rejects to file
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java.rej
patching file
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
patching file
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
Hunk #3 succeeded at 395 (offset 1 line).
{noformat}
> Cache more efficiently getAll() and get() in FSTableDescriptors
> ---------------------------------------------------------------
>
> Key: HBASE-12219
> URL: https://issues.apache.org/jira/browse/HBASE-12219
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.24, 0.99.1, 0.98.6.1
> Reporter: Esteban Gutierrez
> Assignee: Esteban Gutierrez
> Labels: scalability
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12219-0.98.patch, HBASE-12219-0.99.addendum.patch,
> HBASE-12219-0.99.patch, HBASE-12219-v1.patch, HBASE-12219-v1.patch,
> HBASE-12219.v0.txt, HBASE-12219.v2.patch, HBASE-12219.v3.patch, list.png
>
>
> Currently table descriptors and tables are cached once they are accessed for
> the first time. Next calls to the master only require a trip to HDFS to
> lookup the modified time in order to reload the table descriptors if
> modified. However in clusters with a large number of tables or concurrent
> clients and this can be too aggressive to HDFS and the master causing
> contention to process other requests. A simple solution is to have a TTL
> based cached for FSTableDescriptors#getAll() and
> FSTableDescriptors#TableDescriptorAndModtime() that can allow the master to
> process those calls faster without causing contention without having to
> perform a trip to HDFS for every call. to listtables() or getTableDescriptor()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
