[
https://issues.apache.org/jira/browse/HBASE-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192913#comment-14192913
]
Hadoop QA commented on HBASE-12402:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678611/hbase-12402_v1.patch
against trunk revision .
ATTACHMENT ID: 12678611
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3782 checkstyle errors (more than the trunk's current 3781 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11550//console
This message is automatically generated.
> ZKPermissionWatcher race condition in refreshing the cache leaving stale ACLs
> and causing AccessDenied
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-12402
> URL: https://issues.apache.org/jira/browse/HBASE-12402
> Project: HBase
> Issue Type: Bug
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 0.98.8, 0.99.2
>
> Attachments: hbase-12402_v1.patch
>
>
> In testing, we have seen an issue where a region in a newly created table
> will throw AccessDeniedException.
> There seems to be a race condition in the ZKPermissionWatcher when it is just
> starting up, and a new table is created around the same time.
> The master just created the table, and adds permissions to acl table:
> {code}
> 2014-10-30 19:21:26,494 DEBUG
> [MASTER_TABLE_OPERATIONS-ip-172-31-32-87:60000-0] access.AccessControlLists:
> Writing permission with rowKey loadtest_d1 hrt_qa: RWXCA
> {code}
> One of the region servers is just starting:
> {code}
> Thu Oct 30 19:21:11 UTC 2014 Starting regionserver on ip-172-31-32-90
> 2014-10-30 19:21:13,915 INFO [main] util.VersionInfo: HBase
> 0.98.4.2.2.0.0-1194-hadoop2
> {code}
> The node creation event is received
> {code}
> 2014-10-30 19:21:26,764 DEBUG [regionserver60020-EventThread]
> access.ZKPermissionWatcher: Updating permissions cache from node loadtest_d1
> with data:
> PBUF\x0A0\x0A\x06hrt_qa\x12&\x08\x03""\x0A\x16\x0A\x07default\x12\x0Bloadtest_d1
> \x00 \x01 \x02 \x03 \x04
> {code}
> which put the write data to the cache, only to be invalidated later shortly:
> {code}
> ...
> 2014-10-30 19:21:26,855 DEBUG [RS_OPEN_REGION-ip-172-31-32-90:60020-1]
> access.ZKPermissionWatcher: Updating permissions cache from node
> tabletwo_copytable_cell_versions_two with data:
> PBUF\x0AI\x0A\x06hrt_qa\x12?\x08\x03";\x0A/\x0A\x07default\x12$tabletwo_copytable_cell_versions_two
> \x00 \x01 \x02 \x03 \x04
> 2014-10-30 19:21:26,856 DEBUG [RS_OPEN_REGION-ip-172-31-32-90:60020-1]
> access.ZKPermissionWatcher: Updating permissions cache from node loadtest_d1
> with data: PBUF
> 2014-10-30 19:21:26,856 DEBUG [RS_OPEN_REGION-ip-172-31-32-90:60020-1]
> access.ZKPermissionWatcher: Updating permissions cache from node
> tablefour_cell_version_snapshots_copy with data: PBUF
> ...
> {code}
> Notice that the threads are different. The first one is the zk event
> notification thread, vs the other is the thread from OpenRegionHandler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)