[
https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100973#comment-13100973
]
[email protected] commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1748/#review1831
-----------------------------------------------------------
Ship it!
- Michael
On 2011-09-08 08:39:24, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1748/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-08 08:39:24)
bq.
bq.
bq. Review request for hbase and Todd Lipcon.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Trunk version of HBASE-4313.
bq.
bq. commit 2d0e127fbe13be7d1fda0a7dff91c0717dbb13a0
bq. Author: Jonathan Hsieh <[email protected]>
bq. Date: Thu Aug 25 00:10:27 2011 -0700
bq.
bq. HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.
bq. - Cleanup table creation
bq. - Add proper MiniCluster shutdown
bq. - Separate each corruption into a separate test
bq.
bq.
bq. This addresses bug HBASE-4313.
bq. https://issues.apache.org/jira/browse/HBASE-4313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 7ff8eb5
bq.
bq. Diff: https://reviews.apache.org/r/1748/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. This unittest class passes.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments:
> 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch,
> 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch,
> hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the
> same table. This refactor essentially preserves what is tested but isolates
> each error type so that there is no bleed over in error from table to table.
> This will also enable the writing of other simple to read tests for other
> hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
