[ 
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199946#comment-14199946
 ] 

Usha Kuchibhotla commented on HBASE-11677:
------------------------------------------

Hi, When building the code after fixing the logger instances, I get the below 
test errors. Could someone help me fix these?

Tests in error: 
  
testGenerateAndLoad(org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv):
 File does not exist: 
hdfs://localhost:58859/home/ukuchibhotla/.m2/repository/org/apache/hbase/hbase-client/0.99.0-SNAPSHOT/hbase-client-0.99.0-SNAPSHOT.jar
  
testRunFromOutputCommitter(org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv):
 File does not exist: 
hdfs://localhost:58859/home/ukuchibhotla/.m2/repository/org/apache/hbase/hbase-hadoop-compat/0.99.0-SNAPSHOT/hbase-hadoop-compat-0.99.0-SNAPSHOT.jar
  testRestartRsHoldingTable(org.apache.hadoop.hbase.mttr.IntegrationTestMTTR): 
java.lang.NullPointerException
  
testLoadAndVerify(org.apache.hadoop.hbase.test.IntegrationTestWithCellVisibilityLoadAndVerify):
 File does not exist: 
hdfs://localhost:46182/home/ukuchibhotla/.m2/repository/org/apache/hbase/hbase-client/0.99.0-SNAPSHOT/hbase-client-0.99.0-SNAPSHOT.jar
  testLoadAndVerify(org.apache.hadoop.hbase.test.IntegrationTestLoadAndVerify): 
File does not exist: 
hdfs://localhost:33476/home/ukuchibhotla/.m2/repository/org/apache/hbase/hbase-client/0.99.0-SNAPSHOT/hbase-client-0.99.0-SNAPSHOT.jar
  
testContinuousIngest(org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList):
 File does not exist: 
hdfs://localhost:33232/home/ukuchibhotla/.m2/repository/org/apache/hbase/hbase-client/0.99.0-SNAPSHOT/hbase-client-0.99.0-SNAPSHOT.jar

Thanks,
Usha

> Make Logger instance modifiers consistent
> -----------------------------------------
>
>                 Key: HBASE-11677
>                 URL: https://issues.apache.org/jira/browse/HBASE-11677
>             Project: HBase
>          Issue Type: Task
>            Reporter: Sean Busbey
>            Priority: Minor
>              Labels: beginner, sonar
>
> We have some instances of Logger that are missing one of being private, 
> static, and final.
> ex from HealthChecker.java, missing final
> {code}
>     private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment 
> for the commonly used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to