[ 
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated HBASE-12279:
---------------------------------
    Attachment: HBASE-12279-2014-11-07-v2.patch

Because HBASE-12272 has been committed this patch can now be done simply 
created by running
{code}mvn generate-sources -Pcompile-thrift{code}
on a clean checkout of the source tree.

To ensure this doesn't break any existing tests I've attached the patch for the 
current master branch so Jenkins can do a verification run.

I think that this patch file shouldn't be used for the actual commit. I think 
the above command should be used as it is much easier to do the same on all 
branches.

> Generated thrift files were generated with the wrong parameters
> ---------------------------------------------------------------
>
>                 Key: HBASE-12279
>                 URL: https://issues.apache.org/jira/browse/HBASE-12279
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0, 0.98.0, 0.99.0
>            Reporter: Niels Basjes
>             Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
>
>         Attachments: HBASE-12279-2014-10-16-v1.patch, 
> HBASE-12279-2014-11-07-v2.patch
>
>
> It turns out that the java code generated from the thrift files have been 
> generated with the wrong settings.
> Instead of the documented 
> ([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
>  
> [thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
>  
> {code}
> thrift -strict --gen java:hashcode 
> {code}
> the current files seem to be generated instead with
> {code}
> thrift -strict --gen java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to