[
https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211483#comment-14211483
]
Hadoop QA commented on HBASE-12404:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681421/0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch
against trunk revision .
ATTACHMENT ID: 12681421
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 103
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * <a
href="https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html";>Hadoop
Interface Classification</a>
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[],
byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}, and
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[],
byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call,
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+ {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+ or {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call,
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+method's argument. Calling {@link
org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[],
org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+ final Connection connection, final List<Get> gets, final KeyFromRow<K>
kfr) throws IOException {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestCatalogJanitor
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11667//console
This message is automatically generated.
> Task 5 from parent: Replace internal HTable constructor use with
> HConnection#getTable (0.98, 0.99)
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-12404
> URL: https://issues.apache.org/jira/browse/HBASE-12404
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: stack
> Fix For: 0.99.2
>
> Attachments:
> 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt,
> 12404v2.txt, 12404v3.txt, 12404v5.txt
>
>
> Do the step 5. from the [~ndimiduk] list in parent issue. Go through src
> code and change all new HTable to instead be connection.getTable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
