[ 
https://issues.apache.org/jira/browse/HBASE-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213334#comment-14213334
 ] 

Jimmy Xiang commented on HBASE-12480:
-------------------------------------

I see. 

{noformat}
 +                && serverName != null && onlineServers.contains(serverName)) {
{noformat}
No need this change. If serverName is null, onlineServers should not contain it.

bq. isServerOnline(ServerName) will return false when serverName is null (It 
will be null in case 2 above)
In master branch, the server should be never null if it is in these states.

{noformat}
+      case FAILED_CLOSE:
+      case FAILED_OPEN:
+        unassign(regionInfo, regionState.getServerName(), null);
...
{noformat}
Should use invokeUnAssign.


> Regions in FAILED_OPEN/FAILED_CLOSE should be processed on master failover 
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-12480
>                 URL: https://issues.apache.org/jira/browse/HBASE-12480
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>            Reporter: Virag Kothari
>            Assignee: Virag Kothari
>             Fix For: 2.0.0, 0.98.9, 0.99.2
>
>         Attachments: HBASE-12480.patch
>
>
> For zk assignment, we used to process this regions. For zk less assignment, 
> we should do the same



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to