[
https://issues.apache.org/jira/browse/HBASE-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214319#comment-14214319
]
stack commented on HBASE-12358:
-------------------------------
bq. Before we go about with the patch and the doc, from the code changes we
found that it would be better to go with BRs rather than BBs.
Can you say more why you found this [~ram_krish]?
bq. ...we would need the the getXXXBuffer() methods in the Cell itself ....
You mean a getFamilyArray would have a companion getFamilyBuffer, and so on?
What would the getFamilyBuffer return?
Doing comparisons when the bytes are off heap, how would that work?
bq. As Anoop already pointed out for all the filters and exposed APIs the user
might need to use Cell.hasArray() to determine whether to use getXXXArray() or
getXXXBuffer().
We'd have to do this even if Cell was BR backed?
bq. Or we should go about with a totally new Cell in the read path that does
not extend Cell.
We want to have a single Interface that can be pasesd through the read-path and
then do different implementations? It'd be interesting if we couldn't figure
one that works for on-heap/off-heap.
Good stuff
> Create ByteBuffer backed Cell
> -----------------------------
>
> Key: HBASE-12358
> URL: https://issues.apache.org/jira/browse/HBASE-12358
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-12358.patch, HBASE-12358_1.patch,
> HBASE-12358_2.patch
>
>
> As part of HBASE-12224 and HBASE-12282 we wanted a Cell that is backed by BB.
> Changing the core Cell impl would not be needed as it is used in server
> only. So we will create a BB backed Cell and use it in the Server side read
> path. This JIRA just creates an interface that extends Cell and adds the
> needed API.
> The getTimeStamp and getTypebyte() can still refer to the original Cell API
> only. The getXXxOffset() and getXXXLength() can also refer to the original
> Cell only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
