[
https://issues.apache.org/jira/browse/HBASE-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214660#comment-14214660
]
Hadoop QA commented on HBASE-11639:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681884/HBASE-11639_v6.patch
against trunk revision .
ATTACHMENT ID: 12681884
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3795 checkstyle errors (more than the trunk's current 3788 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public List<Tag> encodeVisibilityForReplication(final List<Tag> tags,
final Byte serializationFormat)
+ visibilityString.append(VisibilityConstants.CLOSED_PARAN +
VisibilityConstants.OR_OPERATOR);
+ visibilityString.append(VisibilityConstants.OPEN_PARAN +
VisibilityConstants.NOT_OPERATOR
+ public List<Tag> encodeVisibilityForReplication(List<Tag> tags, Byte
serializationFormat) throws IOException {
+ User.createUserForTesting(conf, User.getCurrent().getShortName(), new
String[] { "supergroup" });
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11704//console
This message is automatically generated.
> [Visibility controller] Replicate the visibility of Cells as strings
> --------------------------------------------------------------------
>
> Key: HBASE-11639
> URL: https://issues.apache.org/jira/browse/HBASE-11639
> Project: HBase
> Issue Type: Improvement
> Components: Replication, security
> Affects Versions: 0.98.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Labels: VisibilityLabels
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-11639_v2.patch, HBASE-11639_v2.patch,
> HBASE-11639_v3.patch, HBASE-11639_v3.patch, HBASE-11639_v5.patch,
> HBASE-11639_v6.patch
>
>
> This issue is aimed at persisting the visibility labels as strings in the WAL
> rather than Label ordinals. This would help in replicating the label
> ordinals to the replication cluster as strings directly and also that after
> HBASE-11553 would help because the replication cluster could have an
> implementation as string based visibility labels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
