[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102353#comment-13102353
 ] 

Ted Yu commented on HBASE-4213:
-------------------------------

In HBaseAdmin.java, javadoc should be added for instantAdd parameter:
{code}
    * @param column column descriptor of column to be added
    * @throws IOException if a remote or network exception occurs
    */
-  public void addColumn(final String tableName, HColumnDescriptor column)
+  public void addColumn(final String tableName, HColumnDescriptor column, 
boolean instantAdd)
   throws IOException {
{code}
Personally I prefer creating an enum, possibly called SCHEMA_OP_TYPE, which 
should contain NORMAL and INSTANT. There are two benefits:
1. the enum is more meaningful for readers
2. SCHEMA_OP_TYPE.INSTANT covers add/delete. This may provide benefit for 
related code.
This is minor, though.

> Support for fault tolerant, instant schema updates with out master's 
> intervention (i.e with out enable/disable and bulk assign/unassign) through 
> ZK.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4213
>                 URL: https://issues.apache.org/jira/browse/HBASE-4213
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Subbu M Iyer
>            Assignee: Subbu M Iyer
>             Fix For: 0.92.0
>
>         Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
> 4213-V5-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
> HBASE-4213-Instant_schema_change.patch, 
> HBASE-4213_Instant_schema_change_-Version_2_.patch, 
> HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of 
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify 
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to