[ 
https://issues.apache.org/jira/browse/HBASE-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215357#comment-14215357
 ] 

Hadoop QA commented on HBASE-12471:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12681991/12404v9.txt
  against trunk revision .
  ATTACHMENT ID: 12681991

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 93 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    + * <a 
href="https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html";>Hadoop
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], 
byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}, and
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], 
byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, 
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+   {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, 
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+   or {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, 
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, 
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+method's argument.  Calling {@link 
org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], 
org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestClusterId
                  org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
                  
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  org.apache.hadoop.hbase.fs.TestBlockReorder
                  org.apache.hadoop.hbase.TestMetaTableAccessor
                  org.apache.hadoop.hbase.coprocessor.TestMasterObserver
                  org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
                  org.apache.hadoop.hbase.util.TestHBaseFsck
                  org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload
                  
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
                  
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
                  org.apache.hadoop.hbase.security.access.TestAccessController2
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
                  org.apache.hadoop.hbase.master.TestMaster
                  org.apache.hadoop.hbase.util.TestMergeTable
                  org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
                  org.apache.hadoop.hbase.client.TestHTableMultiplexer
                  
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
                  org.apache.hadoop.hbase.master.TestMasterShutdown
                  org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
                  org.apache.hadoop.hbase.security.access.TestAccessController
                  org.apache.hadoop.hbase.filter.TestFilterWrapper
                  org.apache.hadoop.hbase.filter.TestScanRowPrefix
                  org.apache.hadoop.hbase.master.TestRegionPlacement
                  org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache
                  org.apache.hadoop.hbase.client.TestFromClientSide
                  
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
                  org.apache.hadoop.hbase.replication.TestReplicationWithTags
                  org.apache.hadoop.hbase.TestZooKeeper
                  
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
                  org.apache.hadoop.hbase.TestMultiVersions
                  
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
                  org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
                  org.apache.hadoop.hbase.util.TestRegionSplitter
                  
org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange
                  
org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
                  
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
                  org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
                  org.apache.hadoop.hbase.client.TestFromClientSide3
                  
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.replication.TestMasterReplication
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting
                  org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
                  org.apache.hadoop.hbase.TestMetaTableAccessorNoCluster
                  
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
                  org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
                  org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapreduce.TestCopyTable
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
                  org.apache.hadoop.hbase.regionserver.TestCompactionState
                  org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
                  org.apache.hadoop.hbase.client.TestAdmin2
                  org.apache.hadoop.hbase.TestIOFencing
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.client.TestAdmin1
                  
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap

     {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s):       
at 
org.apache.hadoop.hbase.master.TestMasterNoCluster.testNotPullingDeadRegionServerFromZK(TestMasterNoCluster.java:306)
        at 
org.apache.hadoop.hbase.client.TestReplicasClient.testUseRegionWithReplica(TestReplicasClient.java:530)
        at 
org.apache.hadoop.hbase.replication.regionserver.TestReplicationHLogReaderManager.test(TestReplicationHLogReaderManager.java:180)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11718//console

This message is automatically generated.

> Task 4. replace internal ConnectionManager#{delete,get}Connection use with 
> #close, #createConnection (0.98, 0.99)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12471
>                 URL: https://issues.apache.org/jira/browse/HBASE-12471
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: 
> 0001-HBASE-12471-Task-4.-replace-internal-ConnectionManag.patch, 12404v9.txt, 
> 124471v4.txt, 12471v10.txt, 12471v2.txt, 12471v3.txt, 12471v6.txt, 
> 12471v7.txt, 12471v9.txt
>
>
> Let me do this. A bunch of this was done in HBASE-12404 Let me see if can 
> find more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to