[
https://issues.apache.org/jira/browse/HBASE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219632#comment-14219632
]
stack commented on HBASE-10671:
-------------------------------
Looks great [~enis]
What is reasoning that has RetriesExhaustedException private yet
RowTooBigException public? Ditto QuotaExceededException and ThrottlingException
In PreemptiveFastFailException you add imports but do not mark the class?
This is an interesting one on protobufutil...
@InterfaceAudience.Private // TODO: some clients (Hive, etc) use this class
We need to be able to evolve this class. I suppose we'll just have the
conversation w/ the hive crew when the time comes. Agree keeping it private is
the way to go.
Base64 is private because? Its general utility? You thinking folks should go
elsewhere for this kinda thing? Or you want to remove it (Do we use it
anywhere other than in tooling?)
Thats a fancy-pants test. Nice.
+1
> Add missing InterfaceAudience annotations for classes in hbase-common and
> hbase-client modules
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-10671
> URL: https://issues.apache.org/jira/browse/HBASE-10671
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 0.99.2
>
> Attachments: hbase-10671_v1.patch, hbase-10671_v2.patch,
> hbase-10671_v3.patch
>
>
> In this jira, we'll add missing InterfaceAudience annotations to classes in
> the client visible modules (hbase-client and hbase-common).
> Parent jira is for deciding on whether some of the classes should be private
> or public.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
