[ 
https://issues.apache.org/jira/browse/HBASE-11992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221692#comment-14221692
 ] 

Virag Kothari commented on HBASE-11992:
---------------------------------------

Skimmed the patch and looks fine to me. 
Only one problem I could notice in TableCFsTracker: 
{code}
@Override
     public synchronized void nodeDataChanged(String path) {
       if (path.equals(node)) {
         super.nodeDataChanged(path);
         readTableCFsZnode();
       }
     }
{code}
This isn't right. Master branch doesn't have readTableCFsZnode() in this 
method. 



> Backport HBASE-11367 (Pluggable replication endpoint) to 0.98
> -------------------------------------------------------------
>
>                 Key: HBASE-11992
>                 URL: https://issues.apache.org/jira/browse/HBASE-11992
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.9
>
>         Attachments: HBASE-11992_0.98_1.patch, HBASE-11992_0.98_2.patch, 
> hbase-11367_0.98.patch
>
>
> ReplicationSource tails the logs for each peer. HBASE-11367 introduces 
> ReplicationEndpoint which is customizable per peer. ReplicationEndpoint is 
> run in the same RS process and instantiated per replication peer per region 
> server. Implementations of this interface handle the actual shipping of WAL 
> edits to the remote cluster.
> This issue is for backporting HBASE-11367 to 0.98.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to