[
https://issues.apache.org/jira/browse/HBASE-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12471:
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Three green runs on v5. Committed on the back of open +1s from @enis and
[~ndimiduk]
What I committed was v5 with this comment up top:
{code}
HBASE-12471 Task 4. replace internal
ConnectionManager#{delete,get}Connection use with #close, #createConnection
(0.98, 0.99) under src/main/java
Move from HConnection to ClusterConnection or Connection
Use unmanaged connections where we use managed previous
(used the jdk7
https://docs.oracle.com/javase/7/docs/technotes/guides/language/try-with-resources.html
idiom).
In ZKConfig, synchronize on Configuration rather than make a copy.
Making a copy we were dropping hbase configs in certain test context
(could not find the zk ensemble because default port).
In tests, some move to the new style connection setup but mostly
fixes for premature connection close or adding cleanup where it
was lacking.
{code}
There is more to do in here so can resolve the parent issue.
> Task 4. replace internal ConnectionManager#{delete,get}Connection use with
> #close, #createConnection (0.98, 0.99) under src/main/java
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-12471
> URL: https://issues.apache.org/jira/browse/HBASE-12471
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
> Attachments:
> 0001-HBASE-12471-Task-4.-replace-internal-ConnectionManag.patch, 12404v9.txt,
> 124471v4.txt, 12471.reapply.reapply.v5.txt, 12471.reapply.reapply.v5.txt,
> 12471.reapply.reapply.v5.txt, 12471.reapply.reapply.v5.txt,
> 12471.reapply.reapply.v5.txt, 12471.reapply.txt, 12471.reapply.v4.txt,
> 12471.reapplyv2.txt, 12471.reapplyv2.txt, 12471.reapplyv3.txt, 12471v10.txt,
> 12471v10.txt, 12471v11.txt, 12471v2.txt, 12471v3.txt, 12471v6.txt,
> 12471v7.txt, 12471v9.txt
>
>
> Let me do this. A bunch of this was done in HBASE-12404 Let me see if can
> find more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
