[ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225122#comment-14225122 ]
Hadoop QA commented on HBASE-12559: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683611/12559-v3.txt against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14. ATTACHMENT ID: 12683611 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 7 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 3781 checkstyle errors (more than the master's current 3779 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + * <code>rpc UpdateMasterConfiguration(.UpdateMasterConfigurationRequest) returns (.UpdateMasterConfigurationResponse);</code> + * <code>rpc UpdateMasterConfiguration(.UpdateMasterConfigurationRequest) returns (.UpdateMasterConfigurationResponse);</code> {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestNamespace org.apache.hadoop.hbase.client.TestScannerTimeout org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.TestMultiVersions org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove org.apache.hadoop.hbase.coprocessor.TestWALObserver org.apache.hadoop.hbase.client.TestTableSnapshotScanner org.apache.hadoop.hbase.constraint.TestConstraint org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove org.apache.hadoop.hbase.TestZooKeeper org.apache.hadoop.hbase.coprocessor.TestHTableWrapper org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint org.apache.hadoop.hbase.client.TestHTableMultiplexer org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.client.TestReplicaWithCluster org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort org.apache.hadoop.hbase.client.TestSnapshotMetadata org.apache.hadoop.hbase.snapshot.TestExportSnapshot org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.TestJMXListener org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface org.apache.hadoop.hbase.client.TestFromClientSide3 org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11829//console This message is automatically generated. > Provide LoadBalancer with online configuration capability > --------------------------------------------------------- > > Key: HBASE-12559 > URL: https://issues.apache.org/jira/browse/HBASE-12559 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt > > > StochasticLoadBalancer has many knobs which user can adjust. > It would increase productivity by allowing StochasticLoadBalancer to accept > online configuration changes. > LoadBalancer already implements setConf(Configuration) method which reloads > relevant configuration parameters. > We need to add updateMasterConfiguration() method to Admin which invokes the > setConf() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)