[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225648#comment-14225648
]
Hadoop QA commented on HBASE-12518:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683725/12518.txt
against master branch at commit 24f19328eb4a756b95cb0ab13d089479afc7626d.
ATTACHMENT ID: 12683725
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3781 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//console
This message is automatically generated.
> Task 4 polish. Remove CM#{get,delete}Connection
> -----------------------------------------------
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.0.0, 0.99.2
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12518.txt
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connectionKey, staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnection connection, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(e.getKey(), staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnectionKey connectionKey, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(this, false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * Currently, clients cleanup by calling {@link
> #deleteConnection(Configuration)}. This will
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * HConnectionManager.deleteConnection(conf, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> ConnectionManager.deleteConnection(conf);
> ./hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
> HConnectionManager.deleteConnection(admin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/table.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
> * {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
> * {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
> * {@link HConnectionManager#deleteConnection(Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
> * {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig2);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java.orig:
> if (connection !=
> null)HConnectionManager.deleteConnection(configuration);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java:
> HConnectionManager.deleteConnection(c.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java:
>
> HConnectionManager.deleteConnection(this.connection.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java:
> HConnectionManager.deleteConnection(UTIL.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableLocator.java:
> HConnectionManager.deleteConnection(UTIL.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableLocator.java:
> * {@link
> HConnectionManager#deleteConnection(org.apache.hadoop.conf.Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java:
> HConnectionManager.deleteConnection(conf);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java:
> HConnectionManager.deleteConnection(conf);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
