[
https://issues.apache.org/jira/browse/HBASE-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103425#comment-13103425
]
ramkrishna.s.vasudevan commented on HBASE-4373:
-----------------------------------------------
@Stack
But except in AssignmentManager.handleHBCK(RegionTransitionData data)
for the M_ZK_REGION_OFFLINE case we use
assign(regionInfo, false); with force=false. All other places force=true.
And also when you take the HBaseAdmin.assign() api then allowing the user to
use force=false will not yield him the result as he may not be aware in what
state the znode is currently in. So i felt like removing the parameter.
Pls provide your suggestions.
> HBaseAdmin.assign() doesnot use force flag
> ------------------------------------------
>
> Key: HBASE-4373
> URL: https://issues.apache.org/jira/browse/HBASE-4373
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
>
> The HBaseAdmin.assign()
> {code}
> public void assign(final byte [] regionName, final boolean force)
> throws MasterNotRunningException, ZooKeeperConnectionException, IOException
> {
> getMaster().assign(regionName, force);
> }
> {code}
> In the HMaster we call
> {code}
> Pair<HRegionInfo, ServerName> pair =
> MetaReader.getRegion(this.catalogTracker, regionName);
> if (pair == null) throw new
> UnknownRegionException(Bytes.toString(regionName));
> if (cpHost != null) {
> if (cpHost.preAssign(pair.getFirst(), force)) {
> return;
> }
> }
> assignRegion(pair.getFirst());
> if (cpHost != null) {
> cpHost.postAssign(pair.getFirst(), force);
> }
> {code}
> The force flag is not getting used. May be we need to update the javadoc or
> do not provide the force flag as a parameter if we are not going to use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
