[
https://issues.apache.org/jira/browse/HBASE-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229866#comment-14229866
]
Solomon Duskis commented on HBASE-12598:
----------------------------------------
[~stack] ht.setAutoFlush(false, false) has the same affect as
ht.setAutoFlush(false). ht.setAutoFlush(false, true) is the same as as
ht.setAutoFlushTo(false). setAutoFlush is kind of convoluted.
In terms of this issue vs. HBASE-12490, please use HBASE-12490's patch instead
of this patch. I created this issue more out of confusion about how issues
relate to master vs. branch-1 than a known difference in functionality as it
relates to the different branches.
> Replace uses of setAutoFlush(boolean, boolean) in 0.99.2
> --------------------------------------------------------
>
> Key: HBASE-12598
> URL: https://issues.apache.org/jira/browse/HBASE-12598
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.99.2
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12598B.patch
>
>
> HBASE-12490 changed the 2.0.0 branch. This is a similar change to branch-1.
> The various uses of setAutoFlush() seem to need some tlc. There's a note in
> HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is
> deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to change
> all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if
> possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
> setAutoFlush(false, false) has the same results as
> HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
> same affect as Table.setAutoFlushTo(false), assuming
> HTable.setAutoFlush(false) was not called previously (by default, the second
> parameter, clearBufferOnFail, is true and should remain true according to the
> comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
