[
https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230180#comment-14230180
]
Ted Yu commented on HBASE-12559:
--------------------------------
bq. why not just pass Master SN?
HMaster extends HRegionServer. If one RPC method is defined, should master
config be modified, region server config be modified, or both ?
bq. Why we doing reload conf
conf.reloadConfiguration() is called in CompactSplitThread and HRegionServer.
To my knowledge, this is the way new config is reloaded into daemon.
Here is related code from HRegionServer:
{code}
* Reload the configuration from disk.
*/
public void updateConfiguration() {
LOG.info("Reloading the configuration from disk.");
// Reload the configuration from disk.
conf.reloadConfiguration();
configurationManager.notifyAllObservers(conf);
{code}
bq. blanket changing of configs could have dangerous side effects.
Not sure I follow - conf.reloadConfiguration() is called after various
components have finished initialization. The call wouldn't have immediate
effect if component doesn't refresh / reload with new config.
> Provide LoadBalancer with online configuration capability
> ---------------------------------------------------------
>
> Key: HBASE-12559
> URL: https://issues.apache.org/jira/browse/HBASE-12559
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt,
> 12559-v4.txt, 12559-v5.txt, 12559-v6.txt
>
>
> StochasticLoadBalancer has many knobs which user can adjust.
> It would increase productivity by allowing StochasticLoadBalancer to accept
> online configuration changes.
> LoadBalancer already implements setConf(Configuration) method which reloads
> relevant configuration parameters.
> We need to add updateMasterConfiguration() method to Admin which invokes the
> setConf() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
