[
https://issues.apache.org/jira/browse/HBASE-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231688#comment-14231688
]
Andrew Purtell commented on HBASE-12609:
----------------------------------------
bq. long bandwidth =
this.conf.getLong("replication.source.per.peer.node.bandwidth", 0);
This will be a dynamic function of the hosts and networks involved. We should
determine available bandwidth using one of the established bandwidth estimation
/ flow control algorithms rather than rely on a statically configured value
(which will usually be wrong, even if the operator is top of their game)
> Consider bandwidth throttling in
> ReplicationSource.readAllEntriesToReplicateOrNextFile
> --------------------------------------------------------------------------------------
>
> Key: HBASE-12609
> URL: https://issues.apache.org/jira/browse/HBASE-12609
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Affects Versions: 0.98.8
> Reporter: cuijianwei
> Priority: Minor
>
> The push size in ReplicationSource.shipEdits is controlled by
> 'replicationQueueSizeCapacity' and 'replicationQueueNbCapacity'. When the
> push size is much bigger than throttler's bandwidth(replication throttler is
> enabled), ReplicationSource will have a outgoing bandwidth peak followed by a
> period of sleep controlled by the throttler. How about considering bandwidth
> throttling in ReplicationSource.readAllEntriesToReplicateOrNextFile? such as
> the following code:
> {code}
> // Stop if too many entries or too big
> long bandwidth =
> this.conf.getLong("replication.source.per.peer.node.bandwidth", 0);
> if ((bandwidth > 0 && currentSize > bandwidth) || // ==> also consider
> bandwidth throttling
> currentSize >= this.replicationQueueSizeCapacity ||
> entries.size() >= this.replicationQueueNbCapacity) {
> break;
> }
> {code}
> Then, ReplicationSource will have more steady outgoing bandwidth.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
