[
https://issues.apache.org/jira/browse/HBASE-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232374#comment-14232374
]
Elliott Clark commented on HBASE-12614:
---------------------------------------
Either version is fine. I'm always leary of catching an exception and just
logging it. However I don't think there's a lot of risk in this case. (famous
last words)
> Potentially unclosed StoreFile(s) in DefaultCompactor#compact()
> ---------------------------------------------------------------
>
> Key: HBASE-12614
> URL: https://issues.apache.org/jira/browse/HBASE-12614
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 12614-v1.txt, 12614-v2.txt
>
>
> Here is the related code (around line 129):
> {code}
> for (StoreFile f : readersToClose) {
> f.closeReader(true);
> }
> {code}
> If any closeReader() call throws IOException, the remaining StoreFile(s)
> would not be closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
