[ 
https://issues.apache.org/jira/browse/HBASE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104100#comment-13104100
 ] 

Hudson commented on HBASE-4384:
-------------------------------

Integrated in HBase-TRUNK #2206 (See 
[https://builds.apache.org/job/HBase-TRUNK/2206/])
    HBASE-4384 Hard to tell what causes failure in 
CloseRegionHandler#getCurrentVersion

stack : 
Files : 
* /hbase/trunk/CHANGES.txt
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java


> Hard to tell what causes failure in CloseRegionHandler#getCurrentVersion
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4384
>                 URL: https://issues.apache.org/jira/browse/HBASE-4384
>             Project: HBase
>          Issue Type: Task
>          Components: zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4384.r1.diff
>
>
> The current code goes like:
> {code}
> 172    * Get the node's current version
> 173    * @return The expectedVersion.  If -1, we failed getting the node
> 174    */
> 175   private int getCurrentVersion() {
> 176     int expectedVersion = FAILED;
> 177     try {
> 178       if ((expectedVersion = ZKAssign.getVersion(
> 179           server.getZooKeeper(), regionInfo)) == FAILED) {
> 180         LOG.warn("Error getting node's version in CLOSING state," +
> 181           " aborting close of " + regionInfo.getRegionNameAsString());
> 182       }
> 183     } catch (KeeperException e) {
> 184       LOG.warn("Error creating node in CLOSING state, aborting close of " 
> +
> 185         regionInfo.getRegionNameAsString());
> 186     }
> 187     return expectedVersion;
> 188   }
> 189 }
> {code}
> Both WARN cases would be identical this way. In case of an exception, I think 
> an exception ought to be logged as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to