[
https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jurriaan Mous updated HBASE-12597:
----------------------------------
Attachment: HBASE-12597-v7.patch
Fixed the test failures. (Which was of a move of callIdCntr to Call class, took
some serious debugging to find that one)
Fixed the line length issues.
Will need another build for the javadoc and firebug issues that are mentioned
because the build logs of that build is gone. (404s)
What is the deadline for branch-1?
When can this patch be committed? If Hadoop QA calls it a success? Or are other
steps needed?
> Add RpcClient interface and enable changing of RpcClient implementation
> -----------------------------------------------------------------------
>
> Key: HBASE-12597
> URL: https://issues.apache.org/jira/browse/HBASE-12597
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Jurriaan Mous
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12597-v1.patch, HBASE-12597-v2.patch,
> HBASE-12597-v3.patch, HBASE-12597-v4.patch, HBASE-12597-v4.patch,
> HBASE-12597-v5.patch, HBASE-12597-v6.patch, HBASE-12597-v7.patch,
> HBASE-12597.patch
>
>
> Currently HConnectionImplementation works with the included RpcClient which
> is a direct implementation and not defined by an interface.
> It would be great to be able to swap out the default RpcClient with another
> implementation which can also be controlled by the default
> HConnectionImplementation.
> Suggested changes:
> - Create a RpcClient interface which defines all the ways
> HConnectionImplementation interacts with an RPC client. Like getting a
> blocking protobuf service interface or closing the client.
> - Define which RpcClient implementation to construct by setting a
> configuration variable which defaults to the current RpcClient.
> - Possibly create an abstract RpcClient class to only load all the basic Rpc
> layer configurations to be used in an implementation.
> Why? It enables experimentation with RpcClients which could enable new
> features or could be more performant than the included client.
> I created a new RpcClient implementation based on Netty which can also be
> called asynchronously. It would be great to also be able to use this
> RpcClient in all the default ways and tests to see if there are any issues
> with it.
> https://github.com/jurmous/async-hbase-client/
> https://github.com/jurmous/async-hbase-client/blob/master/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcClient.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
