[
https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237260#comment-14237260
]
Hadoop QA commented on HBASE-12650:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685623/12650-v4.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2092 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * <code><hostname> '{@link #SERVERNAME_SEPARATOR}' <port> '{@link
#SERVERNAME_SEPARATOR}' <startcode></code>.
[email protected](value="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED",
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//console
This message is automatically generated.
> Move ServerName to hbase-common module
> --------------------------------------
>
> Key: HBASE-12650
> URL: https://issues.apache.org/jira/browse/HBASE-12650
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Gaurav Menghani
> Assignee: Ted Yu
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt
>
>
> The idea is to move ServerName to hbase-common, so that other modules like
> hbase-consensus which (would) depend on ServerName, but can't depend on
> hbase-client, since hbase-client would depend on them. Moreover, it looks
> logical that ServerName not be a part of the client module. It is a shared
> class between multiple modules, so it should be in hbase-common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
