[ 
https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237536#comment-14237536
 ] 

Hadoop QA commented on HBASE-12575:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12685664/HBASE-12575.patch
  against master branch at commit 87e44140040ab9a864e592c13f164dcde6ed6c03.
  ATTACHMENT ID: 12685664

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
2091 checkstyle errors (more than the master's current 2089 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    public TableCoprocessorAttribute(Path path, String className, int 
priority, Configuration conf) {
+              LOG.error("Malformed table coprocessor specification: key=" + 
key + ", spec: " + spec);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//console

This message is automatically generated.

> Sanity check table coprocessor classes are loadable
> ---------------------------------------------------
>
>                 Key: HBASE-12575
>                 URL: https://issues.apache.org/jira/browse/HBASE-12575
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Andrew Purtell
>             Fix For: 1.0.0, 2.0.0, 0.98.9
>
>         Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, 
> HBASE-12575.patch, HBASE-12575.patch
>
>
> We load coprocessors and other classes from configuration. In case of a typo 
> in the class name (or deployment problem) a create table / alter table with 
> wrong class name brings down the whole cluster. 
> Master already does sanity check for compression and region split policy 
> classes introduced in HBASE-10591. We should extend that to check some other 
> common cases as well. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to